From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] nefilter: use pr_devel instead of pr_debug
Date: Thu, 22 Apr 2010 12:46:44 +0200 [thread overview]
Message-ID: <4BD02914.9030100@trash.net> (raw)
In-Reply-To: <1271856071-32179-2-git-send-email-jengelh@medozas.de>
Jan Engelhardt wrote:
> Netfilter traditionally used debug prints that were omitted unless
> someone explicitly defined DEBUG. Recently that has no longer been the
> case (see explanation in commit v2.6.30-rc2-184-g4ccb457). Switch our
> pr_debug calls to pr_devel.
The intention of CONFIG_DYNAMIC_DEBUG is exactly to make those debug
statements available dynamically. I presume the mentioned distribution
had a reason to enable that option. Why should we undermine that by
turning debug statements into "devel" statements?
next prev parent reply other threads:[~2010-04-22 10:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 13:21 nf-next: two small ones Jan Engelhardt
2010-04-21 13:21 ` [PATCH 1/2] nefilter: use pr_devel instead of pr_debug Jan Engelhardt
2010-04-22 10:46 ` Patrick McHardy [this message]
2010-04-22 10:53 ` Jan Engelhardt
2010-04-22 11:00 ` Patrick McHardy
2010-04-22 11:01 ` David Miller
2010-04-22 11:04 ` Patrick McHardy
2010-04-22 11:00 ` David Miller
2010-04-22 10:55 ` David Miller
2010-04-21 13:21 ` [PATCH 2/2] netfilter: rectify XT_FUNCTION_MAXNAMELEN usage Jan Engelhardt
2010-04-22 10:48 ` Patrick McHardy
2010-04-26 12:47 ` Jan Engelhardt
2010-04-27 13:35 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD02914.9030100@trash.net \
--to=kaber@trash.net \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.