From: Tejun Heo <tj@kernel.org>
To: Harry Zhang <harry.zhang@amd.com>
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org, hane.Huang@amd.com
Subject: Re: [PATCH 2/2] ahci EM message type auto detect
Date: Thu, 22 Apr 2010 17:36:20 +0200 [thread overview]
Message-ID: <4BD06CF4.2020101@kernel.org> (raw)
In-Reply-To: <1271931409.3745.9.camel@zm-desktop>
Hello,
On 04/22/2010 12:16 PM, Harry Zhang wrote:
> + /* em message type */
> + EM_MSG_TYPE_LED = (1 << 0), /* LED */
> + EM_MSG_TYPE_SAFTE = (1 << 1), /* SAF-TE */
> + EM_MSG_TYPE_SES2 = (1 << 2), /* SES-2 */
> + EM_MSG_TYPE_SGPIO = (1 << 3), /* SGPIO */
Shouldn't the store/show methods be testing the above SGPIO flag?
Also, can you please move this patch before the other one?
Thanks.
--
tejun
prev parent reply other threads:[~2010-04-22 15:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 10:16 [PATCH 2/2] ahci EM message type auto detect Harry Zhang
2010-04-22 15:36 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD06CF4.2020101@kernel.org \
--to=tj@kernel.org \
--cc=hane.Huang@amd.com \
--cc=harry.zhang@amd.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.