From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [PATCH] pv-ops: Fix missing 'ifdef CONFIG_XEN' in acpi
Date: Thu, 22 Apr 2010 09:27:21 -0700
Message-ID: <4BD078E9.3070601@goop.org>
References: <4BC7C657.3010609@cn.fujitsu.com>
	<20100416145604.GC29398@phenom.dumpdata.com>
	<4BCA82FF.20901@cn.fujitsu.com> <4BCA8E9A.6090209@goop.org>
	<20100419133026.GA17501@phenom.dumpdata.com>
	<4BCD3C2B.3030706@cn.fujitsu.com>
	<20100420183301.GA32720@phenom.dumpdata.com>
	<4BCE7120.7020004@cn.fujitsu.com>
	<20100421130045.GA24393@phenom.dumpdata.com>
	<4BCF0352.50909@cn.fujitsu.com> <4BCF28BE.4000206@goop.org>
	<4BCFCAEF.1000206@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4BCFCAEF.1000206@cn.fujitsu.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Yu Zhiguo <yuzg@cn.fujitsu.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
List-Id: xen-devel@lists.xenproject.org

On 04/21/2010 09:05 PM, Yu Zhiguo wrote:
> Hi jeremy,
>
> Jeremy Fitzhardinge wrote:
>   
>>>  #endif
>>> +
>>> +#if !defined(CONFIG_XEN) || (defined(CONFIG_XEN) && !defined(CONFIG_XEN_DOM0_PCI))
>>>   
>>>       
>> As I mentioned in the other mail, there's no need to test CONFIG_XEN.
>>
>>     
> Indeed, thanks for your hint.
> Correct now, please refer to the following.
>   

Better, but:

> -
> +#if (!defined(CONFIG_PCI_MSI) || !defined(CONFIG_XEN_DOM0_PCI))
>   

Isn't there already a XEN MSI CONFIG variable?

    J