From: Jordan Russell <jr-list-2010@quo.to>
To: linux-raid@vger.kernel.org
Subject: raid1.c read_balance() LBD issue?
Date: Thu, 22 Apr 2010 13:21:13 -0500 [thread overview]
Message-ID: <4BD09399.4090901@quo.to> (raw)
raid1.c's read_balance() function has:
const unsigned long this_sector = r1_bio->sector;
Doesn't that need to be:
const sector_t this_sector = r1_bio->sector;
for compatibility with LBD on 32-bit platforms?
It looks as though truncating the sector number to 32 bits could cause
it to read *above* the resync window on an unsync'ed disk.
--
Jordan Russell
next reply other threads:[~2010-04-22 18:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 18:21 Jordan Russell [this message]
2010-05-07 17:37 ` raid1.c read_balance() LBD issue? Jordan Russell
2010-05-07 22:22 ` Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD09399.4090901@quo.to \
--to=jr-list-2010@quo.to \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.