From: Michael Barkowski <michaelbarkowski@ruggedcom.com>
To: David Miller <davem@davemloft.net>
Cc: "khc@pm.waw.pl" <khc@pm.waw.pl>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] WAN: flush tx_queue in hdlc_ppp to prevent panic on rmmod hw_driver.
Date: Thu, 22 Apr 2010 17:55:41 -0400 [thread overview]
Message-ID: <4BD0C5DD.4040304@ruggedcom.com> (raw)
In-Reply-To: <20100422.144339.128290761.davem@davemloft.net>
David Miller wrote:
> From: Michael Barkowski <michaelbarkowski@ruggedcom.com>
> Date: Thu, 22 Apr 2010 15:17:13 -0400
>
>> Krzysztof Halasa wrote:
>>> tx_queue is used as a temporary queue when not allowed to queue skb
>>> directly to the hw device driver (which may sleep). Most paths flush
>>> it before returning, but ppp_start() currently cannot. Make sure we
>>> don't leave skbs pointing to a non-existent device.
>>>
>>> Thanks to Michael Barkowski for reporting this problem.
>> Great - thanks. Will this be going into -stable?
>
> When I think it's cooked long enough in Linus's tree and
> I submit it there. That can take a few weeks.
>
Super. By the way, should have mentioned - tested and works for me
--
Michael Barkowski
prev parent reply other threads:[~2010-04-22 21:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-15 0:09 [PATCH] WAN: flush tx_queue in hdlc_ppp to prevent panic on rmmod hw_driver Krzysztof Halasa
2010-04-16 22:41 ` David Miller
2010-04-22 19:17 ` Michael Barkowski
2010-04-22 21:43 ` David Miller
2010-04-22 21:55 ` Michael Barkowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD0C5DD.4040304@ruggedcom.com \
--to=michaelbarkowski@ruggedcom.com \
--cc=davem@davemloft.net \
--cc=khc@pm.waw.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.