All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Roman Fietze <roman.fietze@telemotive.de>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: port and device of libata.force ID separated by point
Date: Thu, 22 Apr 2010 21:52:49 -0400	[thread overview]
Message-ID: <4BD0FD71.3060602@pobox.com> (raw)
In-Reply-To: <201004211217.12697.roman.fietze@telemotive.de>

On 04/21/2010 06:17 AM, Roman Fietze wrote:
> Hello,
>
> If I understand libata-core correctly, esp. arround line 6572:
>
> 	/* parse id */
> 	p = strchr(id, '.');
> 	...
>
> the optional device is separated from the port in the libata.force ID
> by a point or dot instead of by a colon.
>
> If my assumption is correct, this patch will fix the documentation:
>
> Signed-off-by: Roman Fietze<roman.fietze@telemotive.de>
> ---
>   Documentation/kernel-parameters.txt |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
> index e7848a0..ea5a826 100644
> --- a/Documentation/kernel-parameters.txt
> +++ b/Documentation/kernel-parameters.txt
> @@ -1193,7 +1193,7 @@ and is between 256 and 4096 characters. It is defined in the file
>
>   	libata.force=	[LIBATA] Force configurations.  The format is comma
>   			separated list of "[ID:]VAL" where ID is
> -			PORT[:DEVICE].  PORT and DEVICE are decimal numbers
> +			PORT[.DEVICE].  PORT and DEVICE are decimal numbers
>   			matching port, link or device.  Basically, it matches
>   			the ATA ID string printed on console by libata.  If

applied



      parent reply	other threads:[~2010-04-23  1:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-21 10:17 [PATCH] libata: port and device of libata.force ID separated by point Roman Fietze
2010-04-23  0:37 ` Tejun Heo
2010-04-23  1:52 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BD0FD71.3060602@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=roman.fietze@telemotive.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.