All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <tj@kernel.org>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
	garyhade@us.ibm.com
Subject: Re: [PATCH #upstream] libata: use longer 0xff wait if parallel scan is enabled
Date: Thu, 22 Apr 2010 22:05:08 -0400	[thread overview]
Message-ID: <4BD10054.8030102@garzik.org> (raw)
In-Reply-To: <4BBF058E.6080300@kernel.org>

On 04/09/2010 06:46 AM, Tejun Heo wrote:
> There are some SATA devices which take relatively long to get out of
> 0xff status after reset.  In libata, this timeout is determined by
> ATA_TMOUT_FF_WAIT.  Quantum GoVault is the worst requring about 2s for
> reliable detection.  However, because 2s 0xff timeout can introduce
> rather long spurious delay during boot, libata has been compromising
> at the next longest timeout of 800ms for HHD424020F7SV00 iVDR drive.
>
> Now that parallel scan is in place for common drivers, libata can
> afford 2s 0xff timeout.  Use 2s 0xff timeout if parallel scan is
> enabled.
>
> Please note that the chance of spurious wait is pretty slim w/ working
> SCR access so this will only affect SATA controllers w/o SCR access
> which isn't too common these days.
>
> Please read the following thread for more information on the GoVault
> drive.
>
>    http://thread.gmane.org/gmane.linux.ide/14545/focus=14663
>
> Signed-off-by: Tejun Heo<tj@kernel.org>
> Cc: Gary Hade<garyhade@us.ibm.com>
> ---
>   drivers/ata/libata-core.c |   18 ++++++++++++------
>   include/linux/libata.h    |   11 ++++++-----
>   2 files changed, 18 insertions(+), 11 deletions(-)

applied



      reply	other threads:[~2010-04-23  2:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-09 10:46 [PATCH #upstream] libata: use longer 0xff wait if parallel scan is enabled Tejun Heo
2010-04-23  2:05 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BD10054.8030102@garzik.org \
    --to=jeff@garzik.org \
    --cc=garyhade@us.ibm.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.