Re: SATA driver sata_sil24

[Robert Hancock <hancockrwd@gmail.com>]

On 04/22/2010 04:33 PM, Richard Mawson wrote:
> Tejun,
>
> On Thu, Apr 22, 2010 at 03:33:55PM +0200, Tejun Heo wrote:
>>> If you have any suggestions as to what the likely problem is, or
>>> things to look for I am all ears.
>>
>> Please try non-xen vanialla kernel and report the failing kernel log.
>
> I have compiled 2.6.33-2, and the same thing happens.
> That is, modprobe sata_sil24 prints one message to the console suggesting the PCI slot,
> then freezes the system.
>
> Unfortunately it doesn't seem to have managed to write anything to messages/kernel.log,
> which is on a p-ata disk.
>
> I managed to hand copy some of the output from alt-sysrq-t which looks like it includes the
> stack running as a result of the modprobe -- does this help to explain where the problem is?
> This was manually copied, so there might be a typo or two:
>
> c03118f8 ? schedule+0x897/0x94e
> c014406a ? ktime_get_ts+0xd7/0xdf
> c0217b42 ? cfq_rb_erase+0x1b/0x2a
> c021f449 ? number+0x149/0x20e
> c023a9cb ? vgacon_scroll+0x180/0x19a
> c0194e0c ? __insert_vmap_area+0x5e/0x96
> c017fac3 ? __alloc_pages_nodemask+0xe2/0x4ec
> c019b409 ? cache_alloc_refill+0x63/0x417
> c02995c9 ? pci_conf1_write+0xb2/0xc0
> c029a9fb ? raw_pci_write+0x4e/0x56
> c029aa40 ? pci_write+0x1c/0x21
> c0228a3e ? pci_bus_write_config_dword+0x46/0x50
> c022ae0c ? pcie_set_readrq+0x8c/0x9e
> f9f185bc ? sil24_init_one+0x1ax/0x21a [sata_sil24]
> c022d899 ? local_pci_probe+0xb/0xc
> c022de7d ? pci_device_probe+0x41/0x63
> c0287489 ? driver_probe_device+0x76/0xfe
> c0287451 ? __driver_attach+0x40/0x5b
> c0286dcd ? bus_for_each_dev0x37/0x5f
> c0287270 ? driver_attach+0x11/0x13
> c0287411 ? __driver_attach+0x0/0x5b
> c0286852 ? bus_add_driver+0xd6/0x201
> c028766b ? driver_register+0x87/0xe0
> c022e050 ? __pci_register_driver+0x33/0x89
> f9f1d000 ? sil24_init+0x0/0x14 [sata_sil24]
> c010112d ? do_one_initcall+0x44/0x120
> c014f1c2 ? sys_init_module+0xa7/0x1d7
> c03130f5 ? syscall_call+0x7/0xb
>
> I don't know that it is relevant, but the pcie card is plugged into a pci-pcie
> converter card.
>
>
> Let me know if there is anything else I can supply to help analyse this (anything
> I do will have to be in the next couple of days as thats all the time I have to
> return the goods for a refund!!).

Hmm, that seems like this line in drivers/ata/sata_sil24.c:

         /* Set max read request size to 4096.  This slightly increases
          * write throughput for pci-e variants.
          */
         pcie_set_readrq(pdev, 4096);

Can you try commenting out or deleting that line and rebuilding, and see 
if things work better? That's not really a solution, but if it worked, 
it would indicate there's something about the system configuration with 
that converter card installed that explodes when trying to set the max 
read request size. In that case can you post the output of "lspci -vv" 
and the full dmesg boot log?