From: Chris Moore <moore@free.fr>
To: Guillaume LECERF <glecerf@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Cc: linux-mtd <linux-mtd@lists.infradead.org>,
Wolfram Sang <w.sang@pengutronix.de>,
Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH v3 5/8] mtd: cfi_cmdset_0002: do not fail on no extended query table as they are both optional
Date: Fri, 23 Apr 2010 07:27:40 +0200 [thread overview]
Message-ID: <4BD12FCC.2070307@free.fr> (raw)
In-Reply-To: <20100422083606.17166.52192.stgit@shiryu.yomgui.biz>
Hi,
Le 22/04/2010 10:36, Guillaume LECERF a écrit :
[snip]
>
> - bootloc = extp->TopBottom;
> - if ((bootloc != 2)&& (bootloc != 3)) {
> - printk(KERN_WARNING "%s: CFI does not contain boot "
> - "bank location. Assuming top.\n", map->name);
> - bootloc = 2;
> - }
> + bootloc = extp->TopBottom;
> + if ((bootloc != 2)&& (bootloc != 3)) {
> + printk(KERN_WARNING "%s: CFI does not contain boot "
> + "bank location. Assuming top.\n", map->name);
> + bootloc = 2;
> + }
>
>
[snip]
It is not your fault, Guillaume, but this whole "Assuming top" stuff is
completely bogus :(
(The most obvious, but not the only, bug is that it actually sets
bootloc to 2 which is bottom :( )
Uwe Kleine-Koenig submitted a patch for this ages ago which I tried to
ping. See these threads :
http://thread.gmane.org/gmane.linux.drivers.mtd/22176
http://thread.gmane.org/gmane.linux.drivers.mtd/22266
*Please*, David, could we get this cleaned up?
Cheers,
Chris
next prev parent reply other threads:[~2010-04-23 5:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 8:35 [PATCH v3 1/8] mtd: cfi_probe: enter Auto Select Mode after filling cfi->cfiq members Guillaume LECERF
2010-04-22 8:35 ` [PATCH v3 2/8] mtd: cfi_probe: make the addresses used to enter Auto Select Mode variable Guillaume LECERF
2010-04-22 8:35 ` [PATCH v3 3/8] mtd: cfi_probe: add support for SST 0x0701 vendorname Guillaume LECERF
2010-04-22 8:36 ` [PATCH v3 4/8] mtd: cfi_probe: use P_ID_* definitions instead of hardcoded values Guillaume LECERF
2010-04-22 8:36 ` [PATCH v3 5/8] mtd: cfi_cmdset_0002: do not fail on no extended query table as they are both optional Guillaume LECERF
2010-04-23 5:27 ` Chris Moore [this message]
2010-04-23 13:58 ` Guillaume LECERF
2010-04-22 8:36 ` [PATCH v3 6/8] mtd: cfi_cmdset_0002: add CFI detection for SST 39VF{16, 32}xx chips Guillaume LECERF
2010-04-22 8:36 ` [PATCH v3 7/8] mtd: cfi_cmdset_0002: add CFI detection for SST 39VF{32, 64}xxB chips Guillaume LECERF
2010-04-22 8:36 ` [PATCH v3 8/8] mtd: cfi_util: do not printk if no extended query table Guillaume LECERF
2010-04-23 1:39 ` Wolfram Sang
2010-04-23 1:37 ` [PATCH v3 1/8] mtd: cfi_probe: enter Auto Select Mode after filling cfi->cfiq members Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD12FCC.2070307@free.fr \
--to=moore@free.fr \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=glecerf@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.