From: Avi Kivity <avi@redhat.com>
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: no need to test bit before setting dirty bit these days
Date: Fri, 23 Apr 2010 13:31:49 +0300 [thread overview]
Message-ID: <4BD17715.1020406@redhat.com> (raw)
In-Reply-To: <20100423174835.0c231699.yoshikawa.takuya@oss.ntt.co.jp>
On 04/23/2010 11:48 AM, Takuya Yoshikawa wrote:
> As Avi pointed out, testing bit part in mark_page_dirty() was important
> in the days of shadow paging, but currently EPT and NPT has already become
> common and the chance of faulting a page more that once per iteration is
> small. So let's remove the test bit to avoid extra access.
>
Applied, thanks.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
prev parent reply other threads:[~2010-04-23 10:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-23 8:48 [PATCH] KVM: no need to test bit before setting dirty bit these days Takuya Yoshikawa
2010-04-23 10:31 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD17715.1020406@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.