From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O5INB-0007Bm-EK
	for qemu-devel@nongnu.org; Fri, 23 Apr 2010 08:52:45 -0400
Received: from [140.186.70.92] (port=37790 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O5INA-0007Be-AQ
	for qemu-devel@nongnu.org; Fri, 23 Apr 2010 08:52:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <mjt@tls.msk.ru>) id 1O5IN8-0003v1-NC
	for qemu-devel@nongnu.org; Fri, 23 Apr 2010 08:52:44 -0400
Received: from isrv.corpit.ru ([81.13.33.159]:33344)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <mjt@tls.msk.ru>) id 1O5IN8-0003uk-FF
	for qemu-devel@nongnu.org; Fri, 23 Apr 2010 08:52:42 -0400
Message-ID: <4BD19816.4050506@msgid.tls.msk.ru>
Date: Fri, 23 Apr 2010 16:52:38 +0400
From: Michael Tokarev <mjt@tls.msk.ru>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] give some useful error messages when tap
	open fails
References: <20100422092826.EF03612B5C@gandalf.tls.msk.ru>
	<m3d3xrlsqb.fsf@blackfin.pond.sub.org>
	<4BD196BB.6050603@redhat.com>
In-Reply-To: <4BD196BB.6050603@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

Kevin Wolf wrote:
> Am 22.04.2010 11:52, schrieb Markus Armbruster:
>> Michael Tokarev <mjt@tls.msk.ru> writes:
>>
>>> In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints
>>> (with fprintf) something like this:
>>>
[]
>>>      TFR(fd = open("/dev/net/tun", O_RDWR));
>>>      if (fd < 0) {
>>> -        fprintf(stderr, "warning: could not open /dev/net/tun: no virtual network emulation\n");
>>> +        qemu_error("could not open /dev/net/tun: %m\n");
>>>          return -1;
> 
> I'm not sure where this %m is defined exactly (Linux specific? Maybe
> BSDs, too?), but it doesn't seem to work with mingw.

The file being patched is tap-linux.c.
I noted this in my first email.

Thanks!

/mjt