Re: [PATCH 1/3] SELinux: standardize return code handling in policydb.c

[Joshua Brindle <method@manicmethod.com>]

Eric Paris wrote:
> policydb.c has lots of different standards on how to handle return paths on
> error.  For the most part transition to
>
> 	rc=errno
> 	if (failure)
> 		goto out;
> [...]
> out:
> 	cleanup()
> 	return rc;
>
> Instead of doing cleanup mid function, or having multiple returns or other
> options.  This doesn't do that for every function, but most of the complex
> functions which have cleanup routines on error.
>

Any chance the same fixes could be made in libsepol policydb.c? :)

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.