All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Mahoney <jeffm@suse.com>
To: ReiserFS Mailing List <reiserfs-devel@vger.kernel.org>,
	Edward Shishkin <edward.shishkin@gmail.com>
Subject: Re: [PATCH] reiserfsprogs: fix use after free with fsck_progress
Date: Fri, 23 Apr 2010 09:47:05 -0400	[thread overview]
Message-ID: <4BD1A4D9.3030508@suse.com> (raw)
In-Reply-To: <4BC789C2.4030207@suse.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 04/15/2010 05:48 PM, Jeff Mahoney wrote:
>  fsck_progress uses fs to get the log file handle but fs is freed before
>  fsck_progress is caleld when it's about to print the "finished" message.
> 
>  When glibc is run with:
>  MALLOC_CHECK_=3
>  MALLOC_PERTURB_=69
> 
>  as is the default on newer versions of openSUSE, it poisons freed memory
>  to detect conditions like this. As a result, reiserfsck segfaults on these
>  systems.
> 
>  This patch fixes fsck to close the file system after printing the completion
>  message.
> 
>  Edward, I'm working on adding support to check extended attributes, so please
>  hold off on an update until I post those patches early next week.

BTW, until this fix is released in an actual update, it can be worked
around by just un-setting the two variables mentioned above.

- -Jeff

- -- 
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/

iEYEARECAAYFAkvRpNkACgkQLPWxlyuTD7IfJACgp/qHg+2Rb+Qo57NwdH4m84Nn
z3IAniFX5QBBe3C/uGoN9B0IFSye5awG
=7Num
-----END PGP SIGNATURE-----

      reply	other threads:[~2010-04-23 13:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-15 21:48 [PATCH] reiserfsprogs: fix use after free with fsck_progress Jeff Mahoney
2010-04-23 13:47 ` Jeff Mahoney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BD1A4D9.3030508@suse.com \
    --to=jeffm@suse.com \
    --cc=edward.shishkin@gmail.com \
    --cc=reiserfs-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.