From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH] drivers/ata/libata-eh.c: fix unused variable warning Date: Fri, 23 Apr 2010 18:07:24 +0400 Message-ID: <4BD1A99C.8010803@ru.mvista.com> References: <1271858846-1706-1-git-send-email-antonf@turbolinux.com.cn> <20100421152404.62699040@lxorguk.ukuu.org.uk> <4BCF1247.8080508@gmail.com> <4BCFA50E.80800@gmail.com> <4BD13E84.2040204@kernel.org> <20100423064332.GA22988@shell.devel.redhat.com> <4BD145B0.8080102@kernel.org> <4BD1A62E.5070602@garzik.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wy0-f174.google.com ([74.125.82.174]:60753 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756419Ab0DWOIQ (ORCPT ); Fri, 23 Apr 2010 10:08:16 -0400 Received: by wyb39 with SMTP id 39so5582529wyb.19 for ; Fri, 23 Apr 2010 07:08:13 -0700 (PDT) In-Reply-To: <4BD1A62E.5070602@garzik.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Jeff Garzik Cc: Tejun Heo , Jeff Garzik , Fang Wenqi , linux-ide@vger.kernel.org, Alan Cox , antonf@turbolinux.com.cn Hello. Jeff Garzik wrote: >>>>> Sorry that the title should be: >>>>> "fix uninitialized variable warning" >>>>> >>>>> not >>>>> "fix unused variable warning" >>>>> >>>>> Need I re-send the patch mail ? >>>> >>>> Yes, please do so. gcc 4.4.1 generates a spurious warning on it too. >>>> >>>> Acked-by: Tejun Heo >>> >>> It's not a spurious warning. The code failed to fully initialize all >>> fields of the ata_taskfile structure, prior to copying the ata_taskfile >>> structure into qc->result_tf. >> >> Hmmmm.... right, I've always thought it was gcc not noticing the >> structure is being initialized in ata_eh_read_log_10h() but it >> actually is noticing much more, so something like the following is >> more appropriate? >> >> Subject: libata: fully initialize @tf in ata_eh_read_log_10h() >> >> ata_eh_read_log_10h() filled @tf only partially. It didn't cause any >> correctness issues but triggered spruious uninitialized variable >> warning. Do ata_tf_init() before filling in @tf. >> >> Signed-off-by: Tejun Heo > > Sorry, I should have also pointed out that a fix went upstream to > Linus in the last batch of fixes... I thought Tejun was fixing a different function, no? > Jeff MBR, Sergei