From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH 6 of 6] PV on HVM suspend\resume
Date: Fri, 23 Apr 2010 16:08:56 -0700 [thread overview]
Message-ID: <4BD22888.1060305@goop.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1004221610060.11380@kaball-desktop>
On 04/22/2010 08:17 AM, Stefano Stabellini wrote:
> +static void do_hvm_suspend(void)
> +{
> + int err;
> + int cancelled = 1;
> +
> + shutting_down = SHUTDOWN_SUSPEND;
> +
> + err = stop_machine_create();
> + if (err) {
> + printk(KERN_ERR "xen suspend: failed to setup stop_machine %d\n", err);
> + goto out;
> + }
> +
> +#ifdef CONFIG_PREEMPT
> + /* If the kernel is preemptible, we need to freeze all the processes
> + to prevent them from being in the middle of a pagetable update
> + during suspend. */
> + err = freeze_processes();
> + if (err) {
> + printk(KERN_ERR "xen suspend: freeze failed %d\n", err);
> + goto out_destroy_sm;
>
This won't compile with CONFIG_PREEMPT enabled, because out_destroy_sm
is missing below.
J
next prev parent reply other threads:[~2010-04-23 23:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 15:17 [PATCH 6 of 6] PV on HVM suspend\resume Stefano Stabellini
2010-04-23 23:08 ` Jeremy Fitzhardinge [this message]
2010-04-25 23:25 ` Stefano Stabellini
2010-04-26 19:03 ` Jeremy Fitzhardinge
2010-04-27 5:08 ` Stefano Stabellini
2010-04-27 8:50 ` Pasi Kärkkäinen
2010-04-27 13:50 ` Konrad Rzeszutek Wilk
2010-04-27 18:32 ` Jeremy Fitzhardinge
2010-05-03 17:31 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD22888.1060305@goop.org \
--to=jeremy@goop.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.