Re: Xawtv sparc 64bit fix

[Mauro Carvalho Chehab <mchehab@redhat.com>]

Guy Martin wrote:
> 
> Hi,
> 
> Here is an old patch of mine which I tried to submit in 2006 but never
> got it. I didn't really know who was xawtv's maintainer at that time.
> 
> 
> 
> The calculation to compute the 64bit alignement in struct-dump.c is
> plain wrong. The alignment has to be computed with a structure
> containing a char and then a 64bit integer and then substract the
> pointer of the 64bit int to the one of the char.
> 
> This fix v4l-info doing a Bus Error on sparc with structs containing
> 64 bit integer following a non 64bit field aligned on a 8 byte boundary
> like v4l2_standard.
> 
> 
> Signed-off-by: Guy Martin <gmsoft@tuxicoman.be>

I tried to compile it (x86_64 arch) and your patch produced two warnings:

../structs/struct-dump.c: In function ‘print_struct’:
../structs/struct-dump.c:48: warning: cast from pointer to integer of different size
../structs/struct-dump.c:48: warning: cast from pointer to integer of different size

Could you please fix it?

> 
> 
> Regards,
>   Guy
> 


-- 

Cheers,
Mauro