From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oren Laadan Subject: Re: [PATCH][usercr] Add numeric hdr.type to ckptinfo Date: Sun, 25 Apr 2010 16:25:04 -0400 Message-ID: <4BD4A520.3070706@cs.columbia.edu> References: <20100421022314.GA25133@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100421022314.GA25133-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Sukadev Bhattiprolu Cc: Containers List-Id: containers.vger.kernel.org Pulled, thanks. Sukadev Bhattiprolu wrote: > From: Sukadev Bhattiprolu > Date: Tue, 20 Apr 2010 19:08:08 -0700 > Subject: [PATCH 1/1] Add the numeric value of hdr.type > > Debug messaages into dmesg rightly print only the numeric value of the > CKPT_HDR type. ckptinfo prints the descriptive macro. But to correlate > the two, one has to dive into the source to find the record type say 302 > in dmesg and then find CKPT_HDR_FILE_DESC in ckptinfo output. Would be > easier if ckptinfo printed both the numeric value and descriptive macro. > > Signed-off-by: Sukadev Bhattiprolu > --- > ckptinfo.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ckptinfo.c b/ckptinfo.c > index 6190301..09b9db4 100644 > --- a/ckptinfo.c > +++ b/ckptinfo.c > @@ -182,8 +182,8 @@ static int image_read_obj(int fd, struct ckpt_hdr **hh) > if (ret == 0) > return 0; > > - VERBOSE("info: [@%lu] object %s len %d\n", > - __filepos, hdr_to_str(h.type), h.len); > + VERBOSE("info: [@%lu] object %3d %s len %d\n", > + __filepos, h.type, hdr_to_str(h.type), h.len); > > p = malloc(h.len); > if (!p) {