From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1O6DOk-0004mp-LB for mharc-grub-devel@gnu.org; Sun, 25 Apr 2010 21:46:10 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O6DOh-0004kZ-Ec for grub-devel@gnu.org; Sun, 25 Apr 2010 21:46:07 -0400 Received: from [140.186.70.92] (port=47049 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O6DOg-0004ji-8a for grub-devel@gnu.org; Sun, 25 Apr 2010 21:46:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O6DOd-0006V7-Pt for grub-devel@gnu.org; Sun, 25 Apr 2010 21:46:06 -0400 Received: from mail-ew0-f214.google.com ([209.85.219.214]:64146) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O6DOd-0006V1-LG for grub-devel@gnu.org; Sun, 25 Apr 2010 21:46:03 -0400 Received: by ewy6 with SMTP id 6so3975580ewy.32 for ; Sun, 25 Apr 2010 18:46:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=mbkW6TcuIjwmOzosdDPVospGcIXXt7pkkxbt00/3Kuw=; b=tlKOtq40lYsCnkgQz3D4XsS0kTbd8kizGOg9F0wOuale0GiZA/LTzAFDCjZr6qePSz g3RiTD+/jgZbQDgOvVyCqdGlx2M3cD4X36UyIGilZsYQRRPoQIlsst/EcM4RUcA+k4JS L2El4mGClRK6Cv223WxwuZc5Lf13dOAW8iY7M= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=dwA8zp+pwatjhxjEzINW68a/FvgjPo0dyMaB26JSYMAcklvdD1Dem/O8qMaqQO8WK5 PnHKe5RYDpQ8RRU/XlvkXjcfhKC5geLcpwBPf/wSZxpGD4s8UfPIT9vLxizH74t0hMzk p+mnsMHUvh7LecJBHDZ4jPC0p7SKwQKA+AKTs= Received: by 10.213.49.144 with SMTP id v16mr1361145ebf.46.1272246362807; Sun, 25 Apr 2010 18:46:02 -0700 (PDT) Received: from debian.bg45.phnet (gprs19.swisscom-mobile.ch [193.247.250.19]) by mx.google.com with ESMTPS id 13sm1769793ewy.5.2010.04.25.18.46.00 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 25 Apr 2010 18:46:01 -0700 (PDT) Message-ID: <4BD4F04D.8030005@gmail.com> Date: Mon, 26 Apr 2010 03:45:49 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20091109) MIME-Version: 1.0 To: The development of GNU GRUB References: <4BC60B1D.8080609@t-online.de> In-Reply-To: <4BC60B1D.8080609@t-online.de> X-Enigmail-Version: 0.95.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig2CE2D9389BB725E50215AF35" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] Fix Cygwin path handling X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Apr 2010 01:46:08 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig2CE2D9389BB725E50215AF35 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Christian Franke wrote: > The Cywin path handling is broken since > make_system_path_relative_to_its_root() functionality was moved from > the lib script to misc.c. > > This patch should fix this. It reuses the Cygwin specific code from > getroot.c:grub_get_prefix() which apparently is a different > implementation of the same function. > > I would suggest to remove grub_get_prefix(), it is now only used in > grub-emu.c and sparc64/ieee1275/grub-setup.c. Not included in the > patch, should be done in a separate commit. > > > 2010-04-14 Christian Franke > > * util/grub-mkconfig_lib.in (make_system_path_relative_to_its_root)= : > Remove broken Cygwin path conversion. > * util/misc.c: [__CYGWIN__] Add include and define. > [__CYGWIN__] (get_win32_path): Copy function from getroot.c, modify= > for Cygwin 1.7. > (make_system_path_relative_to_its_root): Simplify loop, replace ear= ly > return by break. > [__CYGWIN__] Add conversion to win32 path. > + /* Include leading slash. */ + offset =3D 0; + break; Why do you make this change? It seems to make the behaviour of make_path_= relative_to_its root inconsistent since E.g. /boot/grub -> grub /etc -> /etc Can we decide to either always include this slash or never to? I prefer n= ever to include it since it's the way it is now and I prefer to keep it t= o avoid possible breakage. > > > -----------------------------------------------------------------------= - > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig2CE2D9389BB725E50215AF35 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iF4EAREKAAYFAkvU8FYACgkQNak7dOguQgktrgEApF7o9KCU4jn984KfQq3+EbcF jIBy19WRCpHzLAtwoEQBAJygp/nPVdyUjjNzLYPFL/NEqgDdacEDKV0tcOjOjZNO =PZD/ -----END PGP SIGNATURE----- --------------enig2CE2D9389BB725E50215AF35--