From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1O6IFG-0003RP-Gs for mharc-grub-devel@gnu.org; Mon, 26 Apr 2010 02:56:42 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O6IFD-0003Py-Nn for grub-devel@gnu.org; Mon, 26 Apr 2010 02:56:39 -0400 Received: from [140.186.70.92] (port=60499 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O6IFC-0003Ol-9G for grub-devel@gnu.org; Mon, 26 Apr 2010 02:56:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O6IFA-0001cL-EV for grub-devel@gnu.org; Mon, 26 Apr 2010 02:56:38 -0400 Received: from fg-out-1718.google.com ([72.14.220.155]:34874) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O6IFA-0001bt-1s for grub-devel@gnu.org; Mon, 26 Apr 2010 02:56:36 -0400 Received: by fg-out-1718.google.com with SMTP id e21so658412fga.12 for ; Sun, 25 Apr 2010 23:56:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=wwao7KyYe9vW3EQgoWJQ2P98f06IaPPD3VezactT0Tw=; b=oIGdghEVdeGeOH5nVKGyqsM/g2upJha/6sCs0JWPKXUzYYy5UtRjbFc1G7Z/fmzjJz f+caAx/BU3Hnv8+tFFpS8agHVkiyYUqvNMjKSUrNg+0w8gj0zEAkK+i54kS7dFSTa/0P iftPt3S69LlzKKDRAAdbM4NCaC9Y7PbojaS80= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=b4IEz9apUCaGVwlCQY8O3r9HjzmP3faqq5kIuJBjceVvx9DpnvEwxPkPfyoYQGSCJF BfesijykvlaA+oKOxiSukgitb6crekNR+7MD5i5dtnmK+/WWc29MvbqgpWFxrXCZun74 aw81DtGIU0Fc8LSqnwIO4eKM6mX2CbuEm5pj8= Received: by 10.87.22.35 with SMTP id z35mr1034731fgi.46.1272264994735; Sun, 25 Apr 2010 23:56:34 -0700 (PDT) Received: from debian.bg45.phnet (public-docking-hg-4-168.ethz.ch [129.132.244.168]) by mx.google.com with ESMTPS id e3sm4409677fga.19.2010.04.25.23.56.33 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 25 Apr 2010 23:56:33 -0700 (PDT) Message-ID: <4BD53918.9030609@gmail.com> Date: Mon, 26 Apr 2010 08:56:24 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20091109) MIME-Version: 1.0 To: The development of GNU GRUB References: <4BC60B1D.8080609@t-online.de> <4BD4F04D.8030005@gmail.com> <4BD52EE8.5020403@t-online.de> In-Reply-To: <4BD52EE8.5020403@t-online.de> X-Enigmail-Version: 0.95.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigAB305113A7B9F6B59EAED936" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] Fix Cygwin path handling X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Apr 2010 06:56:39 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigAB305113A7B9F6B59EAED936 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Christian Franke wrote: > Vladimir '=CF=86-coder/phcoder' Serbinenko wrote: >> Christian Franke wrote: >> =20 >>> =20 >> + /* Include leading slash. */ >> + offset =3D 0; >> + break; >> Why do you make this change? It seems to make the behaviour of >> make_path_relative_to_its root inconsistent since E.g. >> /boot/grub -> grub >> /etc -> /etc >> =20 > > Could not reproduce. Old and new code always include the leading slash > (except "/" -> ''"). > I actually seen the '/' case and have incorrectly assumed it's always so. However there is still one case when you patch changes the behaviour:= $ grub-mkrelpath / $ ./grub-mkrelpath / / Although: $ ./grub-mkrelpath /mnt/boot/ $ grub-mkrelpath /mnt/boot/ A simple filter at the end of make_path_relative_to_its_root is enough. Just it's better to avoid both inconsistency between mountpoint and root and behaviour change --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enigAB305113A7B9F6B59EAED936 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iF4EAREKAAYFAkvVOR8ACgkQNak7dOguQgkEmAD/R4O1ximT5scUKJ6YzoWycH1N FQgYFMCoaWQjmoqdsYoA/j1l3/stKb9y1xBumbpBjjCRrJ5/aRJeIvySpwdN+KzN =jHfB -----END PGP SIGNATURE----- --------------enigAB305113A7B9F6B59EAED936--