From: Zdenek Kabelac <zkabelac@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH 08/22] Replicator: extend volume_group with list of VGs
Date: Mon, 26 Apr 2010 16:39:19 +0200 [thread overview]
Message-ID: <4BD5A597.9040201@redhat.com> (raw)
In-Reply-To: <20100426142651.GP23791@agk-dp.fab.redhat.com>
Dne 26.4.2010 16:26, Alasdair G Kergon napsal(a):
> On Mon, Apr 12, 2010 at 05:21:36PM +0200, Zdenek Kabelac wrote:
>> Add linked list of opened VGs. List keeps the information
>> about needed and locked and opened VGs for replicator target.
>> Also add missing_vgs status information for quick check and
>> also for possible continuos process_each_lv() where we need
>> to detect whether failure has been caused by missing VG or
>> some other reason.
>
>> diff --git a/lib/metadata/metadata-exported.h b/lib/metadata/metadata-exported.h
>> index 6d40365..9c73dba 100644
>> --- a/lib/metadata/metadata-exported.h
>> +++ b/lib/metadata/metadata-exported.h
>> @@ -250,6 +250,10 @@ struct volume_group {
>> + /* List of wanted/locked and opened VGs */
>> + struct dm_list vgs;
>> + uint32_t missing_vgs;
>
> Can we think up more-specific names?
>
> vg->vgs isn't very informative.
>
In fact I've had there some different names - like remote_vgs, needed_vgs,
deps_vgs....
but I could not decide - and as we now already have pvs, lvs, vgs seems to
be natural extension of naming concept.
vgs - is list of vgnames and flags for openning, including the vg itself -
thus remote_vgs doesn't fit. Needed - seems plain ugly.
So I'm open for new names here - note there are some manipulation functions
which should also use this name.
Zdenek
next prev parent reply other threads:[~2010-04-26 14:39 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-12 15:21 [PATCH 00/22] Replicator 100412 Zdenek Kabelac
2010-04-12 15:21 ` [PATCH 01/22] Add dm_list_splice() for list join Zdenek Kabelac
2010-04-14 11:38 ` Petr Rockai
2010-04-26 13:15 ` Alasdair G Kergon
2010-04-26 13:23 ` Alasdair G Kergon
2010-04-12 15:21 ` [PATCH 02/22] API change for args of process_each_lv_in_vg() Zdenek Kabelac
2010-04-26 13:34 ` Alasdair G Kergon
2010-04-26 13:46 ` Mike Snitzer
2010-04-12 15:21 ` [PATCH 03/22] Replicator: add libdm support Zdenek Kabelac
2010-04-26 13:46 ` Alasdair G Kergon
2010-04-26 14:12 ` Zdenek Kabelac
2010-04-12 15:21 ` [PATCH 04/22] Replicator: suspend/deactivate replicator Zdenek Kabelac
2010-04-26 13:50 ` Alasdair G Kergon
2010-04-12 15:21 ` [PATCH 05/22] Replicator: add lvm support Zdenek Kabelac
2010-04-26 14:10 ` Alasdair G Kergon
2010-04-12 15:21 ` [PATCH 06/22] Replicator: check replicator segment Zdenek Kabelac
2010-04-12 15:21 ` [PATCH 07/22] Replicator: extend _lv_each_dependency() rep. deps Zdenek Kabelac
2010-04-12 15:21 ` [PATCH 08/22] Replicator: extend volume_group with list of VGs Zdenek Kabelac
2010-04-26 14:26 ` Alasdair G Kergon
2010-04-26 14:39 ` Zdenek Kabelac [this message]
2010-04-26 14:27 ` Alasdair G Kergon
2010-04-26 14:35 ` Zdenek Kabelac
2010-04-12 15:21 ` [PATCH 09/22] Replicator: add sorted vgs_list Zdenek Kabelac
2010-04-26 14:34 ` Alasdair G Kergon
2010-04-26 14:56 ` Zdenek Kabelac
2010-04-26 18:01 ` Dave Wysochanski
2010-04-12 15:21 ` [PATCH 10/22] Replicator: add find_replicator_vgs Zdenek Kabelac
2010-04-12 15:21 ` [PATCH 11/22] Replicator: add read and release VGs for rsites Zdenek Kabelac
2010-04-12 15:21 ` [PATCH 12/22] Replicator: use vgs_list for _process_one_vg() Zdenek Kabelac
2010-04-12 15:21 ` [PATCH 13/22] Replicator: use vgs_list for process_each_lv_in_vg() Zdenek Kabelac
2010-04-12 15:21 ` [PATCH 14/22] Replicator: lock_vol() finds missing VGs Zdenek Kabelac
2010-04-12 15:21 ` [PATCH 15/22] Replicator: activate checks for missing vgs Zdenek Kabelac
2010-04-26 14:39 ` Alasdair G Kergon
2010-04-12 15:21 ` [PATCH 16/22] Replicator: update _create_partial_dtree() Zdenek Kabelac
2010-04-12 15:21 ` [PATCH 17/22] Replicator: vg with missing_vgs does not print Zdenek Kabelac
2010-04-12 15:21 ` [PATCH 18/22] Replicator: add replicator to dtree Zdenek Kabelac
2010-04-12 15:21 ` [PATCH 19/22] Replicator: do not remove of replicators' LVs Zdenek Kabelac
2010-04-12 15:21 ` [PATCH 20/22] Replicator: activate change for vgchange Zdenek Kabelac
2010-04-12 15:21 ` [PATCH 21/22] Replicator: add new options for replicator Zdenek Kabelac
2010-04-12 15:21 ` [PATCH 22/22] Replicator: man pages for lvcreate, lvchange Zdenek Kabelac
2010-04-26 14:49 ` Alasdair G Kergon
-- strict thread matches above, loose matches on Subject: below --
2010-03-30 15:17 [PATCH 00/22] Replicator 100430 Zdenek Kabelac
2010-03-30 15:17 ` [PATCH 08/22] Replicator: extend volume_group with list of VGs Zdenek Kabelac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD5A597.9040201@redhat.com \
--to=zkabelac@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.