[U-Boot] [PATCH v3] Program net device MAC addresses after initializing

[Ben Warren <biggerbadderben@gmail.com>]

Hi Prafulla,

On 4/26/2010 3:09 AM, Prafulla Wadaskar wrote:
>
>
>    
>> -----Original Message-----
>> From: u-boot-bounces at lists.denx.de
>> [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Ben Warren
>> Sent: Monday, April 26, 2010 11:26 AM
>> To: u-boot at lists.denx.de
>> Cc: biggerbadderben at gmail.com
>> Subject: [U-Boot] [PATCH v3] Program net device MAC addresses
>> after initializing
>>
>> Add a new function to the eth_device struct for programming a network
>> controller's hardware address.
>>
>> After all network devices have been initialized and the
>> proper MAC address for
>> each has been determined, make a device driver call to
>> program the address
>> into the device.  Only device instances with valid unicast
>> addresses will be
>> programmed.
>>
>> Signed-off-by: Ben Warren<biggerbadderben@gmail.com>
>> Acked-by: Heiko Schocher<hs@denx.de>
>> Acked-by: Prafulla Wadaskar<prafulla@marvell.com>
>> Acked-by: Detlev Zundel<dzu@denx.de>
>> ---
>> v2->v3 Made the sprintf in new function actually work :(
>> v1->v2 Add documentation&  environment variable for
>> overriding new behavior
>> ACKs mentioned above are for v1
>>
>>   README                 |    5 +++++
>>   doc/README.drivers.eth |    7 ++++++-
>>   doc/README.enetaddr    |   10 ++++++----
>>   include/net.h          |    1 +
>>   net/eth.c              |   13 +++++++++++++
>>   5 files changed, 31 insertions(+), 5 deletions(-)
>>
>>      
> ..snip..
>    
>> diff --git a/net/eth.c b/net/eth.c
>> index aff6987..1653ea9 100644
>> --- a/net/eth.c
>> +++ b/net/eth.c
>> @@ -60,6 +60,14 @@ int eth_getenv_enetaddr_by_index(int
>> index, uchar *enetaddr)
>>   	return eth_getenv_enetaddr(enetvar, enetaddr);
>>   }
>>
>> +static int eth_mac_skip(int index)
>> +{
>> +	char enetvar[15];
>> +	char *skip_state;
>> +	sprintf(enetvar, "eth%dmacskip", index);
>> +	return ((skip_state = getenv(enetvar)) != NULL);
>> +}
>> +
>>      
> Hi Ben
> Pls remove the white space in the above line,
> I have tested the patch on guruplug platform and found functional properly
>
>    
Will do.  I'll change your line to "Tested-by" if you don't mind.
> Regards..
> Prafulla . .
>    
Thanks a lot,
Ben