From: Gertjan van Wingerde <gwingerde@gmail.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] rt2x00: remove usage of deprecated noise value
Date: Mon, 26 Apr 2010 22:46:07 +0200 [thread overview]
Message-ID: <4BD5FB8F.4040507@gmail.com> (raw)
In-Reply-To: <1272312567-22853-1-git-send-email-linville@tuxdriver.com>
On 04/26/10 22:09, John W. Linville wrote:
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
> drivers/net/wireless/rt2x00/rt2x00dev.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
> index b93731b..33c2f5f 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00dev.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
> @@ -434,7 +434,6 @@ void rt2x00lib_rxdone(struct rt2x00_dev *rt2x00dev,
> rx_status->mactime = rxdesc.timestamp;
> rx_status->rate_idx = rate_idx;
> rx_status->signal = rxdesc.rssi;
> - rx_status->noise = rxdesc.noise;
> rx_status->flag = rxdesc.flags;
> rx_status->antenna = rt2x00dev->link.ant.active.rx;
>
This could actually go further than just this, as the noise field of rxdesc is only used for this
purpose, so it can actually be removed as well.
However, I guess that can be done as a follow-up, so:
Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
prev parent reply other threads:[~2010-04-26 20:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-26 20:09 [PATCH] rt2x00: remove usage of deprecated noise value John W. Linville
2010-04-26 20:46 ` Gertjan van Wingerde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD5FB8F.4040507@gmail.com \
--to=gwingerde@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.