All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: Michal Marek <mmarek@suse.cz>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-kbuild@vger.kernel.org
Subject: [PATCH 3/6] gconfig: fix to tag NEW symbols correctly
Date: Tue, 27 Apr 2010 15:48:47 +0800	[thread overview]
Message-ID: <4BD696DF.70100@cn.fujitsu.com> (raw)
In-Reply-To: <4BD696C0.8050500@cn.fujitsu.com>

The logic should be reversed.

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
 scripts/kconfig/gconf.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c
index bef1041..1b18329 100644
--- a/scripts/kconfig/gconf.c
+++ b/scripts/kconfig/gconf.c
@@ -1114,7 +1114,7 @@ static gchar **fill_row(struct menu *menu)
 
 	row[COL_OPTION] =
 	    g_strdup_printf("%s %s", _(menu_get_prompt(menu)),
-			    sym && sym_has_value(sym) ? "(NEW)" : "");
+			    sym && !sym_has_value(sym) ? "(NEW)" : "");
 
 	if (opt_mode == OPT_ALL && !menu_is_visible(menu))
 		row[COL_COLOR] = g_strdup("DarkGray");
-- 
1.6.3

  parent reply	other threads:[~2010-04-27  7:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-27  7:48 [PATCH 1/6] kconfig: print symbol type in help text Li Zefan
2010-04-27  7:48 ` Li Zefan
2010-04-27 20:36   ` Randy Dunlap
2010-04-27  7:48 ` Li Zefan [this message]
2010-04-27  7:49 ` [PATCH 4/6] gconfig: fix null pointer warning Li Zefan
2010-04-27 20:36   ` Randy Dunlap
2010-04-27  7:49 ` [PATCH 5/6] xconfig: remove unused function Li Zefan
2010-04-27  7:49 ` [PATCH 6/6] xconfig: Add support to show hidden options which have prompts Li Zefan
2010-04-27 20:42   ` Randy Dunlap
     [not found]     ` <4BD91FEC.6070903@cn.fujitsu.com>
2010-04-29 14:40       ` Randy Dunlap
     [not found]         ` <4BDA35AD.6000407@cn.fujitsu.com>
2010-05-03 18:01           ` Randy Dunlap
2010-04-27 20:36 ` [PATCH 1/6] kconfig: print symbol type in help text Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BD696DF.70100@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.