All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Matthias Weißer" <weisserm@arcor.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] bootdelay can be an environemt variable
Date: Tue, 27 Apr 2010 11:31:32 +0200	[thread overview]
Message-ID: <4BD6AEF4.7080107@arcor.de> (raw)
In-Reply-To: <20100427081956.308F0AFC6A2@gemini.denx.de>

Am 27.04.2010 10:19, schrieb Wolfgang Denk:
> Dear Matthias Weisser,
>
> In message<1272348834-30161-1-git-send-email-weisserm@arcor.de>  you wrote:
>> This patch allows the bootdelay variable contain the name of
>> another variable holding the actual bootdelay value.
>
> Why make the "bootdelay" variable in any way special, compared to all
> other variables? Such inconsistent handling makes no sense to me and
> will only confuse users (not to mentiuon that you don't even attempt
> to document the change).
>
> NAK.
>
> If you need any such evaluation, then perform it for example as part
> of a PREBOOT command. This allows you to do the same thing, in a clean
> way.

It was an attempt to get the bootdelay in an environment variable which 
can be overridden by board specific code.

With this I tried to follow your suggestion in 
http://lists.denx.de/pipermail/u-boot/2010-April/070431.html where you 
NAKed the direct override of bootdelay in board_late_init. So, currently 
my setup is:

bootdelay=gs_bootdelay

and in board.c I set gs_bootdelay according to some GPIO states. Another 
user of the board could simply change bootdelay to an integer and get 
rid of the boards behavior.

I don't see a way to achieve this with a PREBOOT command.

Is there a way that you accept the patch if I add a sentence or two to 
the README?

Regards,
Matthias

  reply	other threads:[~2010-04-27  9:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-27  6:13 [U-Boot] [PATCH] bootdelay can be an environemt variable Matthias Weisser
2010-04-27  8:19 ` Wolfgang Denk
2010-04-27  9:31   ` Matthias Weißer [this message]
2010-04-27 10:24     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BD6AEF4.7080107@arcor.de \
    --to=weisserm@arcor.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.