From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O6pdn-000314-6l
	for qemu-devel@nongnu.org; Tue, 27 Apr 2010 14:36:15 -0400
Received: from [140.186.70.92] (port=57758 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O6pdl-0002zn-PQ
	for qemu-devel@nongnu.org; Tue, 27 Apr 2010 14:36:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <jan.kiszka@web.de>) id 1O6pdg-0006rn-GQ
	for qemu-devel@nongnu.org; Tue, 27 Apr 2010 14:36:13 -0400
Received: from fmmailgate02.web.de ([217.72.192.227]:54689)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <jan.kiszka@web.de>) id 1O6pdg-0006rS-89
	for qemu-devel@nongnu.org; Tue, 27 Apr 2010 14:36:08 -0400
Message-ID: <4BD72E96.8050406@web.de>
Date: Tue, 27 Apr 2010 20:36:06 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <z2jfdaac4d51004262025o432d94f2xe474e09efd1fd634@mail.gmail.com>
In-Reply-To: <z2jfdaac4d51004262025o432d94f2xe474e09efd1fd634@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enigEF51C835ECB9C512DE00AB6A"
Sender: jan.kiszka@web.de
Subject: [Qemu-devel] Re: [PATCH] A bit optimization for tlb_set_page()
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jun Koi <junkoi2004@gmail.com>
Cc: qemu-devel@nongnu.org

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigEF51C835ECB9C512DE00AB6A
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Jun Koi wrote:
> It is not necessary to continue searching for watchpoint when we
> already found one and setup for handling watchpoint in a search loop
> in tlb_set_page().
> This patch breaks that search loop on then.

Acked-by: Jan Kiszka <jan.kiszka@siemens.com>

>=20
> Signed-off-by: Jun Koi <junkoi2004@gmail.com>
>=20
> diff --git a/exec.c b/exec.c
> index 14d1fd7..6329775 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -2240,6 +2240,7 @@ void tlb_set_page(CPUState *env, target_ulong vad=
dr,
>              /* TODO: The memory case can be optimized by not trapping
>                 reads of pages with a write breakpoint.  */

PS: Don't you also want to address this todo while you are at it? :)

>              address |=3D TLB_MMIO;
> +            break;
>          }
>      }
>=20
>=20
>=20


--------------enigEF51C835ECB9C512DE00AB6A
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAkvXLpYACgkQitSsb3rl5xQfkQCgqQIjSF2HSgXhjRDDRdHW3sg6
4t8An14Q0ZhmzQul+IJ/r5Sd7QoKCLSz
=/I0W
-----END PGP SIGNATURE-----

--------------enigEF51C835ECB9C512DE00AB6A--