From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Warren <biggerbadderben@gmail.com>
Date: Tue, 27 Apr 2010 11:46:34 -0700
Subject: [U-Boot] [PATCH] Blackfin: bfin_mac: hook up new write_hwaddr
	function
In-Reply-To: <201004271442.45304.vapier@gentoo.org>
References: <1272392128-13333-1-git-send-email-vapier@gentoo.org>
	<4BD72DE5.9030808@gmail.com> <201004271442.45304.vapier@gentoo.org>
Message-ID: <4BD7310A.4040500@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 4/27/2010 11:42 AM, Mike Frysinger wrote:
> On Tuesday 27 April 2010 14:33:09 Ben Warren wrote:
>    
>> On 4/27/2010 11:15 AM, Mike Frysinger wrote:
>>      
>>> -	bfin_EMAC_setup_addr(dev->enetaddr);
>>> +	bfin_EMAC_setup_addr(dev);
>>>        
>> Are you sure you still want to program it on every init() call?  There's
>> nothing wrong with that, BTW...
>>      
> that's the correct documented behavior ... otherwise, there's no way of
> syncing the env to the hardware.  this is init(), not initialize().
> -mike
>    
Hardware will already be sync'd to the env, since write_hwaddr() now 
automatically gets called after initialize().  The only thing you gain 
from having this call in init() is to program hardware on interfaces 
that were skipped due to the 'ethmacskip' environment variable being set.

regards,
Ben