[ath9k-devel] [PATCH] ath9k: Avoid acktimeout wraps around at bootstrap

[Benoit PAPILLAULT <benoit.papillault@free.fr>]

Lorenzo Bianconi a ?crit :
> Hi all,
>
> I am using ath9k/mac80211 on a PC Engines Alix with a Mikrotik R52n
> card (AR9280 chipset), OpenWrt r21030 (kernel 2.6.32.10) and
> compat-wireless-2010-04-21. I am injecting packets using a VAP in
> monitor mode.
> I have a doubt on ath9k_hw_init_defaults() in hw.c. In particular
> during the bootstrap ah->slottime in ath9k_hw_init_defaults() is set
> to " (u32) -1", so after a HW reset (for example as a result of a
> channel change) in the function ath9k_hw_init_global_settings() the
> acktimeout variable wraps around as ah->slottime is 0xFFFFFFFF and
>
> acktimeout = sifstime + ah->slottime + 3 * ah->coverage_class
>
> In this way we obtain that acktimout is set to 15 us (assuming
> ah->coverage_class set to 0) in the 5GHZ band so less than one of its
> summands (sifstime = 16).
> I wrote this simple patch in order to set ah->slottime to standard
> value for OFDM PHY layer during bootstrap.
>   
Does this have any visible effect or is this patch for strict 
compliance? I am asking this since I see very strange stuff regarding 
ACK (delayed, missing, out of order, ...)

Regards,
Benoit