From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Hellstrom <thomas@shipmail.org>
Subject: Re: [patch 2/5] drivers/gpu/drm/via/via_video.c: fix off by one issue
Date: Wed, 28 Apr 2010 09:52:31 +0200
Message-ID: <4BD7E93F.7010204@shipmail.org>
References: <201004272111.o3RLB3rc019955@imap1.linux-foundation.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.sourceforge.net>
In-Reply-To: <201004272111.o3RLB3rc019955@imap1.linux-foundation.org>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=dri-devel>
List-Post: <mailto:dri-devel@lists.sourceforge.net>
List-Help: <mailto:dri-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.sourceforge.net?subject=subscribe>
Errors-To: dri-devel-bounces@lists.sourceforge.net
To: akpm@linux-foundation.org
Cc: airlied@linux.ie, dri-devel@lists.sourceforge.net, error27@gmail.com
List-Id: dri-devel@lists.freedesktop.org

akpm@linux-foundation.org wrote:
> From: Dan Carpenter <error27@gmail.com>
>
> "fx->lock" is used as the index in "dev_priv->decoder_queue[fx->lock]"
> which is an array of "VIA_NR_XVMC_LOCKS" elements.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> Cc: David Airlie <airlied@linux.ie>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>   

Acked-by: Thomas Hellstrom <thellstrom@vmware.com>

> ---
>
>  drivers/gpu/drm/via/via_video.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN drivers/gpu/drm/via/via_video.c~drivers-gpu-drm-via-via_videoc-fix-off-by-one-issue drivers/gpu/drm/via/via_video.c
> --- a/drivers/gpu/drm/via/via_video.c~drivers-gpu-drm-via-via_videoc-fix-off-by-one-issue
> +++ a/drivers/gpu/drm/via/via_video.c
> @@ -75,7 +75,7 @@ int via_decoder_futex(struct drm_device 
>  
>  	DRM_DEBUG("\n");
>  
> -	if (fx->lock > VIA_NR_XVMC_LOCKS)
> +	if (fx->lock >= VIA_NR_XVMC_LOCKS)
>  		return -EFAULT;
>  
>  	lock = (volatile int *)XVMCLOCKPTR(sAPriv, fx->lock);
> _
>
> ------------------------------------------------------------------------------
> --
> _______________________________________________
> Dri-devel mailing list
> Dri-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/dri-devel
>   


------------------------------------------------------------------------------
--