All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: akpm@linux-foundation.org
Cc: linux-kbuild@vger.kernel.org, shemminger@vyatta.com,
	amwang@redhat.com, arjan@infradead.org
Subject: Re: [patch 1/1] markup_oops: fix perlcritic warnings
Date: Wed, 28 Apr 2010 10:41:44 +0200	[thread overview]
Message-ID: <4BD7F4C8.4080107@suse.cz> (raw)
In-Reply-To: <201004272112.o3RLCrlB020200@imap1.linux-foundation.org>

On 27.4.2010 23:12, akpm@linux-foundation.org wrote:
> From: Stephen Hemminger <shemminger@vyatta.com>
> 
> Turn on strict checking.
> Use local file handles and 3 argument open.

Hi Andrew, Stephen,

as I wrote earlier, this patch is incomplete:
$ perl scripts/markup_oops.pl
Global symbol "$lastword" requires explicit package name at
scripts/markup_oops.pl line 110.
Global symbol "$clobber" requires explicit package name at
scripts/markup_oops.pl line 119.
Global symbol "$lastword" requires explicit package name at
scripts/markup_oops.pl line 119.
Global symbol "$clobber" requires explicit package name at
scripts/markup_oops.pl line 121.
Global symbol "$clobber" requires explicit package name at
scripts/markup_oops.pl line 123.
Global symbol "$clobber" requires explicit package name at
scripts/markup_oops.pl line 128.
Global symbol "$clobber" requires explicit package name at
scripts/markup_oops.pl line 132.
Global symbol "$lastword" requires explicit package name at
scripts/markup_oops.pl line 133.
Global symbol "$clobber" requires explicit package name at
scripts/markup_oops.pl line 143.
Global symbol "$lastword" requires explicit package name at
scripts/markup_oops.pl line 151.
Global symbol "$file" requires explicit package name at
scripts/markup_oops.pl line 268.
Execution of scripts/markup_oops.pl aborted due to compilation errors.

Please drop it from -mm.

Thanks,
Michal

  reply	other threads:[~2010-04-28  8:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-27 21:12 [patch 1/1] markup_oops: fix perlcritic warnings akpm
2010-04-28  8:41 ` Michal Marek [this message]
2010-04-28 23:17   ` Stephen Hemminger
2010-05-06 16:20     ` Michal Marek
2010-05-10 18:09       ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BD7F4C8.4080107@suse.cz \
    --to=mmarek@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=amwang@redhat.com \
    --cc=arjan@infradead.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.