From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paulius Zaleckas <paulius.zaleckas@gmail.com>
Subject: Re: [PATCH 02/13] drm/vmwgfx: Fix single framebuffer detection.
Date: Wed, 28 Apr 2010 11:49:46 +0300
Message-ID: <4BD7F6AA.5090506@gmail.com>
References: <1272390345-3655-1-git-send-email-thellstrom@vmware.com>	<1272390345-3655-2-git-send-email-thellstrom@vmware.com>
	<1272390345-3655-3-git-send-email-thellstrom@vmware.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from darkstar.wilibox.com (darkstar.wilibox.com [195.14.175.138])
	by gabe.freedesktop.org (Postfix) with ESMTP id 4709D9E7A8
	for <dri-devel@lists.freedesktop.org>;
	Wed, 28 Apr 2010 01:56:04 -0700 (PDT)
In-Reply-To: <1272390345-3655-3-git-send-email-thellstrom@vmware.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Thomas Hellstrom <thellstrom@vmware.com>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On 04/27/2010 08:45 PM, Thomas Hellstrom wrote:
> From: Jakob Bornecrantz<jakob@vmware.com>
>
> Signed-off-by: Jakob Bornecrantz<jakob@vmware.com>
> Signed-off-by: Thomas Hellstrom<thellstrom@vmware.com>
> ---
>   drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c |    3 +++
>   1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c
> index 9089159..be88fc6 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c
> @@ -130,6 +130,7 @@ static int vmw_ldu_del_active(struct vmw_private *vmw_priv,
>   	if (list_empty(&ldu->active))
>   		return 0;
>
> +	/* must init otherwise list_empty(&ldu->active) well not work */

Spelling well->will

>   	list_del_init(&ldu->active);
>   	if (--(ld->num_active) == 0) {
>   		BUG_ON(!ld->fb);
> @@ -208,6 +209,8 @@ static int vmw_ldu_crtc_set_config(struct drm_mode_set *set)
>
>   	/* ldu only supports one fb active at the time */
>   	if (dev_priv->ldu_priv->fb&&  vfb&&
> +	    !(dev_priv->ldu_priv->num_active == 1&&
> +	      !list_empty(&ldu->active))&&
>   	dev_priv->ldu_priv->fb != vfb) {
>   		DRM_ERROR("Multiple framebuffers not supported\n");
>   		return -EINVAL;