From: Avi Kivity <avi@redhat.com>
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH 1/1] KVM: x86: avoid unnecessary bitmap allocation when memslot is clean
Date: Wed, 28 Apr 2010 13:27:39 +0300 [thread overview]
Message-ID: <4BD80D9B.3090102@redhat.com> (raw)
In-Reply-To: <4BD7B6F2.9010105@oss.ntt.co.jp>
On 04/28/2010 07:17 AM, Takuya Yoshikawa wrote:
> (2010/04/27 22:46), Takuya Yoshikawa wrote:
>> (2010/04/27 22:18), Avi Kivity wrote:
>>
>>>> Furthermore, the reduced allocations seem to produce good effects for
>>>> other cases too. Actually, I observed that the time for the ioctl was
>>>> more stable than the original one and the average time for dirty slots
>>>> was also reduced by some extent.
>>>
>>> Can you explain why the dirty slots were improved?
>>
>> I cannot do exactly, but vmalloc() might affect the following
>> allocations?
>>
>
>
> Oh, this might be the effect of tlb flush or something?
> - I'm not so confident about mm, but vmalloc(),vfree() does this kind
> of thing?
Yes, vmalloc() does tlb flushes, perhaps that's the cause.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-04-28 10:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-26 9:56 [PATCH 0/1] KVM: x86: avoid unnecessary bitmap allocation when memslot is clean Takuya Yoshikawa
2010-04-26 9:58 ` [PATCH 1/1] " Takuya Yoshikawa
2010-04-27 12:36 ` Marcelo Tosatti
2010-04-27 13:18 ` Avi Kivity
2010-04-27 13:46 ` Takuya Yoshikawa
2010-04-28 4:17 ` Takuya Yoshikawa
2010-04-28 10:27 ` Avi Kivity [this message]
2010-04-28 10:26 ` Avi Kivity
2010-04-28 9:50 ` [PATCH v2] " Takuya Yoshikawa
2010-05-04 9:36 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD80D9B.3090102@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.