All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Rapoport <mike@compulab.co.il>
To: Vimal Singh <vimal.newwork@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>,
	"Ghorai, Sukumar" <s-ghorai@ti.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: Bug in omap2_nand_gpmc_retime?
Date: Wed, 28 Apr 2010 18:40:18 +0300	[thread overview]
Message-ID: <4BD856E2.7070507@compulab.co.il> (raw)
In-Reply-To: <s2hce9ab5791004280826y69ec56d1od0950eadf7cd60e6@mail.gmail.com>

Vimal Singh wrote:
> On Wed, Apr 28, 2010 at 8:35 PM, Mike Rapoport <mike@compulab.co.il> wrote:

>> While working on implementation of gpmc_nand_detect_timings I've seen that
>> omap2_nand_gpmc_retime converts the timings supplied by the platform to
>> ticks and passes it to gpmc_cs_set_timings which in turn converts the
>> timings to ticks. Is it a bug or am I missing something?
> 
> No, 'omap2_nand_gpmc_retime' does not convert timings supplied by the
> platform to tick. Rather it rounds the timings passed by the platform
> to timings in units of 'tick' period.

Thanks for the clarification. I still wonder why is this necessary. 
Anyway gpmc_set_cs_timings will do the conversion?



-- 
Sincerely yours,
Mike.

      reply	other threads:[~2010-04-28 15:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-19  9:50 [PATCH] OMAP: fix gpmc nand setup when no timings supplied Mike Rapoport
2010-04-22  5:19 ` Mike Rapoport
2010-04-22  6:41   ` Ghorai, Sukumar
2010-04-22  6:59     ` Mike Rapoport
2010-04-22  7:59       ` Ghorai, Sukumar
2010-04-22  8:45         ` Mike Rapoport
2010-04-26 18:14           ` Tony Lindgren
2010-04-27  5:07             ` Vimal Singh
2010-04-27  7:43             ` Mike Rapoport
2010-04-27 14:47               ` Tony Lindgren
2010-04-28 15:05                 ` Bug in omap2_nand_gpmc_retime? (was: Re: [PATCH] OMAP: fix gpmc nand setup when no timings supplied) Mike Rapoport
2010-04-28 15:26                   ` Vimal Singh
2010-04-28 15:40                     ` Mike Rapoport [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BD856E2.7070507@compulab.co.il \
    --to=mike@compulab.co.il \
    --cc=linux-omap@vger.kernel.org \
    --cc=s-ghorai@ti.com \
    --cc=tony@atomide.com \
    --cc=vimal.newwork@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.