Re: [PATCH 1/3] ptp: Added a brand new class driver for ptp clocks.

[Randy Dunlap <randy.dunlap@oracle.com>]

On 04/27/10 23:08, Richard Cochran wrote:
> On Tue, Apr 27, 2010 at 03:32:39PM -0700, Randy Dunlap wrote:
>> How do I use the testptp.mk file?
> 
> The makefile uses the KBUILD_OUTPUT environment variable to find the
> kernel includes, with the new header. I do something like this:
> 
>   export ARCH=powerpc
>   export KBUILD_OUTPUT=~/work/kernel/ptp_p2020
>   mkdir -p $KBUILD_OUTPUT
>   make mpc85xx_smp_defconfig
>   make menuconfig
>   make -j3 uImage
>   make headers_install
>   make -C Documentation/ptp -f testptp.mk
> 
>> Drop the ".ko".  We normally don't include that part of the module name.
> 
> Okay, can do. I just imitated what I saw in other Kbuild files.
> 
>>> diff --git a/include/linux/Kbuild b/include/linux/Kbuild
>>> index 2fc8e14..2d616cb 100644
>>> --- a/include/linux/Kbuild
>>> +++ b/include/linux/Kbuild
>>> @@ -318,6 +318,7 @@ unifdef-y += poll.h
>>>  unifdef-y += ppp_defs.h
>>>  unifdef-y += ppp-comp.h
>>>  unifdef-y += pps.h
>>> +unifdef-y += ptp_clock.h
>>>  unifdef-y += ptrace.h
>>>  unifdef-y += quota.h
>>>  unifdef-y += random.h
>>
>> I think that the Kbuild file also needs this line:
>> header-y += ptp_clock.h
>>
>> so that builds that use O=objdir will work, but even with that
>> change, I couldn't get it to work.  (?)
> 
> Well, I am not sure what to do here. I followed the example of the PPS
> code. That code only has the unifdef-y assigment. But now I see that
> Documentation/kbuild/makefiles.txt says unifdef-y is deprecated.
> 
> Can someone clarify what is correct: is just header-y enough?

Yes, it should be.

-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***