From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [PATCH] mini-os: Fix xenbus initialisation
Date: Thu, 29 Apr 2010 13:36:57 -0700
Message-ID: <4BD9EDE9.1070805@goop.org>
References: <20100405232748.GK23034@const.famille.thibault.fr>
	<4BBE2AE5.9050504@goop.org>
	<20100408212505.GG4705@const.famille.thibault.fr>
	<4BBE5B27.6060305@goop.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4BBE5B27.6060305@goop.org>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Samuel Thibault <samuel.thibault@ens-lyon.org>, xen-devel@lists.xensource.com
Cc: Keir Fraser <keir.fraser@eu.citrix.com>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 04/08/2010 03:39 PM, Jeremy Fitzhardinge wrote:
> On 04/08/2010 02:25 PM, Samuel Thibault wrote:
>  =20
>> Jeremy Fitzhardinge, le Thu 08 Apr 2010 12:13:41 -0700, a =E9crit :
>>  =20
>>    =20
>>> Reverting this change (b20f897d6010) makes hvm+stubdom work again.
>>>    =20
>>>      =20
>> Could you try to revert only parts of them?
>>  =20
>>    =20
> I narrowed it down to the first hunk of netfront part of the patch;
> applying everything but this works, adding it causes the failure.
>  =20

Ping?

Keir, can you revert this at least for now?

    J

>     J
>
> diff -r e98537246fe5 extras/mini-os/netfront.c
> --- a/extras/mini-os/netfront.c	Thu Apr 08 15:23:00 2010 -0700
> +++ b/extras/mini-os/netfront.c	Thu Apr 08 15:23:39 2010 -0700
> @@ -407,9 +407,9 @@
>      }
> =20
>      snprintf(path, sizeof(path), "%s/state", nodename);
> -    err =3D xenbus_switch_state(xbt, path, XenbusStateConnected);
> +    err =3D xenbus_switch_state(xbt, path, XenbusStateInitialised);
>      if (err) {
> -        message =3D "switching state";
> +        printk("error writing net initialized: %s\n", err);
>          goto abort_transaction;
>      }
> =20
>
>
>  =20