From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Dave McCracken <dcm@mccr.org>
Cc: xen-devel@lists.xensource.com, Jan Beulich <JBeulich@novell.com>
Subject: Re: Re: [Linux PATCH] Make hugepages work in current git tree
Date: Thu, 29 Apr 2010 14:51:51 -0700 [thread overview]
Message-ID: <4BD9FF77.1040300@goop.org> (raw)
In-Reply-To: <201004291643.16613.dcm@mccr.org>
On 04/29/2010 02:43 PM, Dave McCracken wrote:
> On Thursday 29 April 2010, Jeremy Fitzhardinge wrote:
>
>> Looks reasonable. I rewrote the commit comment:
>>
>> Subject: [PATCH] x86/hugetlb: use set_pmd for huge pte operations
>>
>> On x86, a huge pte is logically a pte, but structurally a pmd. Among
>> other issues, pmds and ptes overload some flags for multiple uses (PAT
>> vs PSE), so it is necessary to know which structural level a pagetable
>> entry is in order interpret it properly.
>>
>> When huge pages are used within a paravirtualized system, it is therefore
>> appropriate to use the pmd set of function to operate on them, so that
>> the hypervisor can correctly validate the update.
>>
>> Signed-off-by: Dave McCracken <dave.mccracken@oracle.com>
>> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
>>
>> Does this look correct?
>>
> Yes, that's an excellent summary of the issue. Thank you.
>
Have you tested this patch on native as well as under Xen?
J
next prev parent reply other threads:[~2010-04-29 21:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-28 14:08 [Linux PATCH] Make hugepages work in current git tree Dave McCracken
2010-04-29 19:30 ` Jeremy Fitzhardinge
2010-04-29 21:43 ` Dave McCracken
2010-04-29 21:51 ` Jeremy Fitzhardinge [this message]
2010-04-30 19:34 ` Dave McCracken
2011-02-10 12:51 ` Kaustubh Kabra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD9FF77.1040300@goop.org \
--to=jeremy@goop.org \
--cc=JBeulich@novell.com \
--cc=dcm@mccr.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.