From: Zdenek Kabelac <zkabelac@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH 1/3] Display errornous pattern to the user
Date: Fri, 30 Apr 2010 13:30:46 +0200 [thread overview]
Message-ID: <4BDABF66.1010306@redhat.com> (raw)
In-Reply-To: <20100430105509.GC14077@agk-dp.fab.redhat.com>
Dne 30.4.2010 12:55, Alasdair G Kergon napsal(a):
> On Fri, Apr 30, 2010 at 11:07:19AM +0200, Zdenek Kabelac wrote:
>> - log_error("invalid filter pattern");
>> + log_error("Invalid filter pattern \"%s\".", v->v.str);
>
> No need to double the quotes there?
> Just %s will do.
> Ack.
>
Well I wanted to make clear what is the expression - which is usually used
with quotes in lvm.conf. If the user uses spaces inside (or dots for sentence
end) it might look a bit confusing in the first sight. Thought the user will
usually immediatelly notice what is wrong - so plain '%s' would do the job as
well, but I would prefer quotes in this case.
Zdenek
next prev parent reply other threads:[~2010-04-30 11:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-30 9:07 [PATCH 0/3] Fix bugs for invalid regex input Zdenek Kabelac
2010-04-30 9:07 ` [PATCH 1/3] Display errornous pattern to the user Zdenek Kabelac
2010-04-30 10:55 ` Alasdair G Kergon
2010-04-30 11:30 ` Zdenek Kabelac [this message]
2010-04-30 11:46 ` Alasdair G Kergon
2010-04-30 11:57 ` Alasdair G Kergon
2010-04-30 9:07 ` [PATCH 2/3] Release allocated pools in error path Zdenek Kabelac
2010-04-30 10:56 ` Alasdair G Kergon
2010-04-30 9:07 ` [PATCH 3/3] Fix internal error for errornous regex insert Zdenek Kabelac
2010-04-30 11:26 ` Alasdair G Kergon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BDABF66.1010306@redhat.com \
--to=zkabelac@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.