From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [PATCH 00 of 10] blkfront pvops updates, v2
Date: Fri, 30 Apr 2010 15:16:13 -0700
Message-ID: <4BDB56AD.3030502@goop.org>
References: <patchbomb.1272664874@agari.van.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <patchbomb.1272664874@agari.van.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Daniel Stodden <daniel.stodden@citrix.com>
Cc: Xen <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 04/30/2010 03:01 PM, Daniel Stodden wrote:
>  * Found the switch [again] for HG to strip those headers -- cheers.
>   

The ideal for me is if you have a git tree I can pull from, but failing
that, the most useful format for mailed patches is something that "git
am" can accept.  It looks like it will take the attachments OK, but it
cats the mail body onto the attachment, so it ends up with the commit
comment twice.  If you have a non-mangling mailer, it's probably easiest
if you just include the full commit comment+patch in the mail body (it's
easier to comment on the patches in mail that way too).

> Oh beautiful. This apparently strips the first comment line together
> with the patch header. Looks buggy.
>
> F*! 
>
> Sorry. Fix/resend?
>   

Did it lose something other than the subject?  git am picked it up from
the email Subject: line, so it didn't matter it was missing from the
patch comment itself.

    J