From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Greg KH <greg@kroah.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org,
Randy Dunlap <randy.dunlap@oracle.com>
Subject: Re: tm6000 compilation breakage on linux-next
Date: Mon, 03 May 2010 14:01:54 -0300 [thread overview]
Message-ID: <4BDF0182.9040903@redhat.com> (raw)
In-Reply-To: <20100503164857.GA5750@kroah.com>
Greg KH wrote:
> On Mon, May 03, 2010 at 01:33:40PM -0300, Mauro Carvalho Chehab wrote:
>> Hi Stephen,
>>
>> Randy reported a breakage while compiling drivers/staging/tm6000, due to
>> this change:
>> commit 1c1b78bee1a94f98deeb9c24b21c4812e191646c
>> Author: Greg Kroah-Hartman <gregkh@suse.de>
>> Date: Thu Apr 29 15:46:07 2010 -0700
>>
>> USB: remove unused usb_buffer_alloc and usb_buffer_free macros
>>
>> Now that all callers are converted over, remove the compatibility
>> functions and all is good.
>>
>> Cc: Daniel Mack <daniel@caiaq.de>
>> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
>>
>> A fix patch is as simple as:
>> s/usb_buffer_alloc/usb_alloc_coherent/
>> s/usb_buffer_free/usb_free_coherent/
>>
>> The problem is that, if I apply such patch on my tree, it will break compilation
>> with upstream.
>
> Not anymore. Those functions are now in Linus's tree, so you can safely
> make the change in your tree now, and all is good :)
Ah, that makes life easier, thanks!
--
Cheers,
Mauro
next prev parent reply other threads:[~2010-05-03 17:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-03 16:33 tm6000 compilation breakage on linux-next Mauro Carvalho Chehab
2010-05-03 16:48 ` Greg KH
2010-05-03 17:01 ` Mauro Carvalho Chehab [this message]
2010-05-03 17:23 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BDF0182.9040903@redhat.com \
--to=mchehab@redhat.com \
--cc=greg@kroah.com \
--cc=linux-next@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.