From: Anthony Liguori <anthony@codemonkey.ws>
To: Nathan Froyd <froydnj@codesourcery.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] fix whitespace bogon in some versions of make
Date: Mon, 03 May 2010 13:06:13 -0500 [thread overview]
Message-ID: <4BDF1095.5050704@codemonkey.ws> (raw)
In-Reply-To: <1272318743-17113-1-git-send-email-froydnj@codesourcery.com>
On 04/26/2010 04:52 PM, Nathan Froyd wrote:
> With three different make binaries I have available, configuring a
> pristine QEMU tree and attempting to make gives the cryptic:
>
> Makefile:27: *** missing separator. Stop.
>
> This patch fixes it (presumably because it makes the output of
> `set-vpath' be an empty string, rather than a bit of whitespace), but I
> don't understand why this hasn't been a problem for other folks before.
>
> Signed-off-by: Nathan Froyd<froydnj@codesourcery.com>
>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> rules.mak | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/rules.mak b/rules.mak
> index 5941b73..7e10432 100644
> --- a/rules.mak
> +++ b/rules.mak
> @@ -40,7 +40,7 @@ cc-option = $(if $(shell $(CC) $1 $2 -S -o /dev/null -xc /dev/null \
> >/dev/null 2>&1&& echo OK), $2, $3)
>
> VPATH_SUFFIXES = %.c %.h %.S %.m %.mak %.texi
> -set-vpath = $(if $1,$(foreach PATTERN,$(VPATH_SUFFIXES), $(eval vpath $(PATTERN) $1)))
> +set-vpath = $(if $1,$(foreach PATTERN,$(VPATH_SUFFIXES),$(eval vpath $(PATTERN) $1)))
>
> # Generate timestamp files for .h include files
>
>
prev parent reply other threads:[~2010-05-03 18:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-26 21:52 [Qemu-devel] [PATCH] fix whitespace bogon in some versions of make Nathan Froyd
2010-04-27 8:09 ` [Qemu-devel] " Paolo Bonzini
2010-05-03 18:06 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BDF1095.5050704@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=froydnj@codesourcery.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.