From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O90J1-00048Y-Jz
	for qemu-devel@nongnu.org; Mon, 03 May 2010 14:23:47 -0400
Received: from [140.186.70.92] (port=60442 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O90Ij-00021n-5p
	for qemu-devel@nongnu.org; Mon, 03 May 2010 14:23:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1O903b-0000oB-P1
	for qemu-devel@nongnu.org; Mon, 03 May 2010 14:07:53 -0400
Received: from mail-qy0-f188.google.com ([209.85.221.188]:63577)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1O903b-0000eQ-LZ
	for qemu-devel@nongnu.org; Mon, 03 May 2010 14:07:51 -0400
Received: by qyk26 with SMTP id 26so4216770qyk.19
	for <qemu-devel@nongnu.org>; Mon, 03 May 2010 11:06:51 -0700 (PDT)
Message-ID: <4BDF10B6.80709@codemonkey.ws>
Date: Mon, 03 May 2010 13:06:46 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] fix curses update
References: <20100420093835.GC9079@chrom.inf.tu-dresden.de>	<x2ifb249edb1004211827m626658d1p97a275e76b1a7104@mail.gmail.com>
	<20100422140811.GA27272@chrom.inf.tu-dresden.de>
In-Reply-To: <20100422140811.GA27272@chrom.inf.tu-dresden.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bernhard Kauer <kauer@os.inf.tu-dresden.de>
Cc: qemu-devel@nongnu.org

On 04/22/2010 09:08 AM, Bernhard Kauer wrote:
> Hi,
>
>    
>> I believe this issue has come up before with a similar patch but
>>      
> well i've submitted such a patch more than two years ago.  Unfortunatelly
> it got never applied, so that I have to patch my Qemu on every update...
>
>
>    
>> someone checked their ncurses and they didn't see the same issue.
>> I just checked and here mvwaddchnstr() does not expect a null-terminated
>> string either, but it skips the \0 characters.
>>      
> This is not conforming to the Single UNIX Specification, which states
> that the string is shown "until a null chtype is encountered". See for
> example:
>    http://www.opengroup.org/onlinepubs/007908775/xcurses/addchstr.html
>
>
>    
>>   So probably we should
>> replace them with spaces or something else,  I wouldn't like to
>> replace a single library call with 80 calls, it's better to go through
>> the string and replace them, maybe in console_write_ch or somewhere
>> else.
>>      
> That would be a one-liner.  Should I send such a patch?
>    

Yes.

Regards,

Anthony Liguori

> Thanks,
>
> 	Bernhard
>
>
>
>