From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm <kvm@vger.kernel.org>, Gleb Natapov <gleb@redhat.com>
Subject: Re: KVM: x86: properly update ready_for_interrupt_injection
Date: Tue, 04 May 2010 12:30:11 +0300 [thread overview]
Message-ID: <4BDFE923.6000201@redhat.com> (raw)
In-Reply-To: <20100504020427.GA30374@amt.cnet>
On 05/04/2010 05:04 AM, Marcelo Tosatti wrote:
> The recent changes to emulate string instructions without entering guest
> mode exposed a bug where pending interrupts are not properly reflected
> in ready_for_interrupt_injection.
>
> The result is that userspace overwrites a previously queued interrupt,
> when irqchip's are emulated in qemu.
>
>
Applied, thanks.
> Fix by always updating state before returning to userspace.
>
Why are we even doing this if irqchip_in_kernel?
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2010-05-04 9:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 2:04 KVM: x86: properly update ready_for_interrupt_injection Marcelo Tosatti
2010-05-04 9:30 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BDFE923.6000201@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.