From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yang Hongyang <yanghy@cn.fujitsu.com>
Subject: Re: [PATCH 3/3]xl: Add command description to command
	table
Date: Wed, 05 May 2010 08:47:22 +0800
Message-ID: <4BE0C01A.9080900@cn.fujitsu.com>
References: <C80607EC.134A0%keir.fraser@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C80607EC.134A0%keir.fraser@eu.citrix.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

Hi Keir,

On 05/05/2010 12:20 AM, Keir Fraser wrote:
> On 04/05/2010 17:10, "Ian Jackson" <Ian.Jackson@eu.citrix.com> wrote:
> 
>>> +extern struct cmd_spec cmd_table[];
>>> +extern int cmdtable_len;
>>> +
>>>  extern struct libxl_ctx ctx;
>>>  extern int logfile;
>>
>> This is wrong.  Use of "extern" in this way in a .c file is incorrect;
>> pure predeclarations should appear only in .h files, and they should
>> appear exactly once each.  That way they can't get out of step.
>>
>> I'll send a patch to fix this at some point.
> 
> I fixed it before I applied it.

Thank you for that!

> 
>  -- Keir
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
> 
> 


-- 
Regards
Yang Hongyang