All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Qemu-devel@nongnu.org
Subject: [Qemu-devel] [Commit 20d97356] Fix OpenBSD build
Date: Wed, 05 May 2010 10:18:56 +0200	[thread overview]
Message-ID: <4BE129F0.8000905@redhat.com> (raw)

Hi Blue Swirl,

did I miss the patch posted for this commit? I can't find it on the
mailing list. I think the BlockDriver declarations should really stay at
the end of the source file of each driver.

What about using a different way to get rid of the static forward
declaration, namely using bdrv_find_format() instead of referencing it
directly? If you agree I'll post patches to revert your change and use
this solution instead.

Kevin

             reply	other threads:[~2010-05-05  8:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-05  8:18 Kevin Wolf [this message]
2010-05-06 17:55 ` [Qemu-devel] Re: [Commit 20d97356] Fix OpenBSD build Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BE129F0.8000905@redhat.com \
    --to=kwolf@redhat.com \
    --cc=Qemu-devel@nongnu.org \
    --cc=blauwirbel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.