From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: KVM hook for code integrity checking Date: Wed, 05 May 2010 12:05:05 +0300 Message-ID: <4BE134C1.1020009@redhat.com> References: <4BDAEF05.1030507@tum.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Suen Chun Hui Return-path: Received: from mx1.redhat.com ([209.132.183.28]:36045 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756879Ab0EEJFK (ORCPT ); Wed, 5 May 2010 05:05:10 -0400 In-Reply-To: <4BDAEF05.1030507@tum.de> Sender: kvm-owner@vger.kernel.org List-ID: On 04/30/2010 05:53 PM, Suen Chun Hui wrote: > Dear KVM developers, > > I'm currently working on an open source security patch to use KVM to > implement code verification on a guest VM in runtime. Thus, it would be > very helpful if someone can point to me the right function or place to > look at for adding 2 hooks into the KVM paging code to: > > 1. Detect a new guest page (which I assume will imply a new pte and > imply a new spte). > Currently, I'm considering putting a hook in the function > mmu_set_spte(), but may there is a better place. > This hook will be used as the main entry point into the code > verification function > This is in general not possible. Hosts with npt or ept will not see new guest ptes. It could be done with physical pages, but you'll have no way of knowing if the pages are used in userspace, the kernel, or both. > 2. Detect a write fault to a read-only spte (eg. for the case of > updating the dirty bit back to the guest pte) > Unfortunately, I'm unable to find an appropriate place where this > actually takes place after reading the code many times. > This hook will be used to prevent a secondary "peek" page from modifying > an existing verified code page. > set_spte() or mmu_set_spte() may work. -- error compiling committee.c: too many arguments to function