From: Ranjith Lohithakshan <ranjithl@ti.com>
To: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Kevin Hilman <khilman@deeprootsystems.com>
Subject: ARCH_OMAP34XX usage in gpio PM code
Date: Wed, 05 May 2010 16:25:55 +0530 [thread overview]
Message-ID: <4BE14EBB.3060205@ti.com> (raw)
Kevin,
Most of the ARCH_OMAP34XX usage has been converted to ARCH_OMAP3,
however there is still a piece of code in gpio on PM branch that refers
ARCH_OMAP34XX
diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
index 7b2178c..0c84aae 100644
--- a/arch/arm/plat-omap/gpio.c
+++ b/arch/arm/plat-omap/gpio.c
@@ -2095,7 +2095,7 @@ static int omap_gpio_suspend(struct sys_device
*dev, pm_me
__raw_writel(bank->suspend_wakeup, wake_set);
spin_unlock_irqrestore(&bank->lock, flags);
-#ifdef CONFIG_ARCH_OMAP34XX
+#ifdef CONFIG_ARCH_OMAP3
if (bank->method == METHOD_GPIO_24XX) {
int j;
for (j = 0; j < 32; j++) {
Shouldn't we be making this change? Let me know and I will include it in
the ads7846 wakeup series.
Just ran into this when testing the ads7846 wakeup support patches and
observing that no gpio wakeup was happening. This part of the code that
was setting the wakeup pad configuration was getting excluded as
ARCH_OMAP34XX is not defined anymore.
Thanks,
Ranjith
next reply other threads:[~2010-05-05 10:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 10:55 Ranjith Lohithakshan [this message]
2010-05-05 21:20 ` ARCH_OMAP34XX usage in gpio PM code Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE14EBB.3060205@ti.com \
--to=ranjithl@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.