From: Avi Kivity <avi@redhat.com>
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
KVM list <kvm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] KVM MMU: fix for forgot mark parent->unsync_children bit
Date: Wed, 05 May 2010 15:30:17 +0300 [thread overview]
Message-ID: <4BE164D9.2030301@redhat.com> (raw)
In-Reply-To: <4BE16265.7060004@cn.fujitsu.com>
On 05/05/2010 03:19 PM, Xiao Guangrong wrote:
> When mapping a new parent to unsync shadow page, we should mark
> parent's unsync_children bit
>
> Reported-by: Marcelo Tosatti<mtosatti@redhat.com>
> Signed-off-by: Xiao Guangrong<xiaoguangrong@cn.fujitsu.com>
> ---
> arch/x86/kvm/mmu.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
> index 97f2ea0..bf35a2f 100644
> --- a/arch/x86/kvm/mmu.c
> +++ b/arch/x86/kvm/mmu.c
> @@ -1374,7 +1374,9 @@ static struct kvm_mmu_page *kvm_mmu_get_page(struct kvm_vcpu *vcpu,
> if (sp->unsync_children) {
> set_bit(KVM_REQ_MMU_SYNC,&vcpu->requests);
> kvm_mmu_mark_parents_unsync(sp);
> - }
> + } else if (sp->unsync)
> + kvm_mmu_mark_parents_unsync(sp);
> +
> trace_kvm_mmu_get_page(sp, false);
> return sp;
> }
>
Which patch does this fix? If it wasn't merge yet, please repost with
the fix included.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-05-05 12:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 12:19 [PATCH 1/2] KVM MMU: fix for forgot mark parent->unsync_children bit Xiao Guangrong
2010-05-05 12:21 ` [PATCH 2/2] KVM MMU: fix race in invlpg code Xiao Guangrong
2010-05-05 12:31 ` Avi Kivity
2010-05-05 12:45 ` Xiao Guangrong
2010-05-05 12:52 ` Avi Kivity
2010-05-05 12:30 ` Avi Kivity [this message]
2010-05-05 12:35 ` [PATCH 1/2] KVM MMU: fix for forgot mark parent->unsync_children bit Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE164D9.2030301@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=xiaoguangrong@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.