Re: [PATCH 2/2] elantech: Report multitouch with proper ABS_MT messages

[Henrik Rydberg <rydberg@euromail.se>]

Dmitry Torokhov wrote:
>> @@ -253,7 +253,6 @@ static void elantech_report_absolute_v2(struct psmouse *psmouse)
>>  
>>  	/* byte 0: n1  n0   .   .   .   .   R   L */
>>  	fingers = (packet[0] & 0xc0) >> 6;
>> -	input_report_key(dev, BTN_TOUCH, fingers != 0);
> 
> Mousedev works a tad better if BTN_TOUCH is reported first. Otherwise
> looks good.
> 
> Henrik, should we report "tool width" as ABS_MT_WIDTH_MAJOR?

I might be missing some context here, I see no prior use of width in the driver.
The answer is either ABS_MT_TOUCH_MAJOR or ABS_MT_WIDTH_MAJOR depending on how
the width is actually computed. Generally, it makes little sense to have
ABS_MT_WIDTH_MAJOR (width of approaching finger) without ABS_MT_TOUCH_MAJOR
(width of touching finger), but it is ok to have only ABS_MT_TOUCH_MAJOR. Things
like thumb detection requires both values to be reliable.

Henrik