From: Henrik Rydberg <rydberg@euromail.se>
To: "Éric Piel" <E.A.B.Piel@tudelft.nl>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Florian Ragwitz <rafl@debian.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [PATCH 2/2] elantech: Report multitouch with proper ABS_MT messages
Date: Wed, 05 May 2010 20:03:28 +0200 [thread overview]
Message-ID: <4BE1B2F0.6010809@euromail.se> (raw)
In-Reply-To: <4BE1A591.3020201@tudelft.nl>
Éric Piel wrote:
> Op 05-05-10 18:38, Dmitry Torokhov schreef:
>> Hi Eric,
>>
>> On Wed, May 05, 2010 at 02:20:46PM +0200, Éric Piel wrote:
> :
>>>
>>> /* byte 0: n1 n0 . . . . R L */
>>> fingers = (packet[0] & 0xc0) >> 6;
>>> - input_report_key(dev, BTN_TOUCH, fingers != 0);
>> Mousedev works a tad better if BTN_TOUCH is reported first. Otherwise
>> looks good.
> I moved it there because somehow I had understood in the
> multi-touch-protocol that all the old events had to be reported after
> the last SYNC_MT. That said, I don't recall any influence on the
> synaptics nor multitouch X drivers. Maybe it matters just for the ABS_*
> events?
The "old" events can be reported anywhere in the sequence, it does not matter.
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-05-05 18:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 12:20 [PATCH 2/2] elantech: Report multitouch with proper ABS_MT messages Éric Piel
2010-05-05 16:38 ` Dmitry Torokhov
2010-05-05 17:06 ` Éric Piel
2010-05-05 17:15 ` Dmitry Torokhov
2010-05-05 17:36 ` Éric Piel
2010-05-05 18:03 ` Henrik Rydberg [this message]
2010-05-05 18:05 ` Florian Ragwitz
2010-05-05 18:11 ` Henrik Rydberg
2010-05-05 18:25 ` Dmitry Torokhov
2010-05-05 18:29 ` Henrik Rydberg
2010-05-05 20:51 ` Dmitry Torokhov
2010-05-05 18:01 ` Henrik Rydberg
2010-05-05 18:14 ` Éric Piel
2010-05-05 18:26 ` Henrik Rydberg
2010-05-05 18:35 ` Éric Piel
2010-05-05 19:06 ` Henrik Rydberg
2010-05-05 21:19 ` Éric Piel
2010-05-05 22:15 ` Henrik Rydberg
2010-05-05 22:53 ` Éric Piel
2010-05-06 8:49 ` Stéphane Chatty
2010-05-06 9:26 ` Mohamed Ikbel Boulabiar
[not found] ` <g2t45cc95261005060217nfbde1177j1dc97028a3b53c3c@mail.gmail.com>
2010-05-06 11:40 ` Henrik Rydberg
2010-05-06 9:22 ` Hennerich, Michael
2010-05-06 11:38 ` Henrik Rydberg
2010-05-05 23:00 ` Éric Piel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE1B2F0.6010809@euromail.se \
--to=rydberg@euromail.se \
--cc=E.A.B.Piel@tudelft.nl \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=rafl@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.