All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Brad Jorsch <anomie@users.sourceforge.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] Count "logo" keys as modifier keys
Date: Wed, 05 May 2010 14:42:32 -0500	[thread overview]
Message-ID: <4BE1CA28.5040208@codemonkey.ws> (raw)
In-Reply-To: <1273033029-15622-3-git-send-email-anomie@users.sourceforge.net>

On 05/04/2010 11:17 PM, Brad Jorsch wrote:
> These are often mapped to Meta on Linux. And I for one use Meta-Tab as
> the equivalent of Windows's Alt-Tab, so not having it marked as a
> modifier leaves the guest thinking it's permanently pressed.
>
> Signed-off-by: Brad Jorsch<anomie@users.sourceforge.net>
>    

Seems reasonable.

Regards,

Anthony Liguori

> ---
>   sdl.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/sdl.c b/sdl.c
> index c155113..cc7b1bb 100644
> --- a/sdl.c
> +++ b/sdl.c
> @@ -385,6 +385,8 @@ static void sdl_process_key(SDL_KeyboardEvent *ev)
>       case 0x9d:                          /* Right CTRL */
>       case 0x38:                          /* Left ALT */
>       case 0xb8:                         /* Right ALT */
> +    case 0xdb:                          /* Left META */
> +    case 0xdc:                         /* Right META */
>           if (ev->type == SDL_KEYUP)
>               modifiers_state[keycode] = 0;
>           else
>    

      reply	other threads:[~2010-05-05 19:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-05  4:17 [Qemu-devel] [PATCH 0/2] Release modifier keys (including Meta) on loss of focus Brad Jorsch
2010-05-05  4:17 ` [Qemu-devel] [PATCH 1/2] Fix clearing modifiers on focus loss Brad Jorsch
2010-05-05  4:17 ` [Qemu-devel] [PATCH 2/2] Count "logo" keys as modifier keys Brad Jorsch
2010-05-05 19:42   ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BE1CA28.5040208@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=anomie@users.sourceforge.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.