From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yang Hongyang <yanghy@cn.fujitsu.com>
Subject: Re: [PATCH]xl: move libxl init functions from xl.c to
	xl_cmdimpl.c
Date: Thu, 06 May 2010 09:12:38 +0800
Message-ID: <4BE21786.40609@cn.fujitsu.com>
References: <4BE0F732.8000005@cn.fujitsu.com>
	<19425.39634.19846.441503@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <19425.39634.19846.441503@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Hi Ian,

On 05/06/2010 12:20 AM, Ian Jackson wrote:
> Yang Hongyang writes ("[Xen-devel] [PATCH]xl: move libxl init functions from xl.c to xl_cmdimpl.c"):
>> Move libxl init functions from xl.c to xl_cmdimpl.c, use a wrapper function
>> xl_init to do libxl init things.
> 
> I don't understand the purpose of this change.

It's my mistake that uses extern vars in .c file this way, Keir fix part of it, but there remains
two declarations in xl.c. My prupose is to correct this usage. But compare to move these
declarations to .h file, I prefer move code related to these vars to xl_cmdimpl.c, because
I think the libxl init and set log functions is more related to command implementations.

> 
> Ian.
> 
> 


-- 
Regards
Yang Hongyang